Fuzzer Migration Follow-ups - #1903
Merged
Byron merged 10 commits intoApr 18, 2024
Merged
Conversation
Prefer executing these files using the OSS-Fuzz or `python` command methods outlined in the `fuzzing/README`. Based on feedback and discussion on: gitpython-developers#1901
This script is meant to be sourced by the OSS-Fuzz file of the same name, rather than executed directly. The shebang may lead to the incorrect assumption that the script is meant for direct execution. Replacing it with this directive instructs ShellCheck to treat the script as a Bash script, regardless of how it is executed. Based @EliahKagan's suggestion and feedback on: gitpython-developers#1901
This script is executed directly, not sourced as is the case with `build.sh`, so it should have an executable bit set to avoid ambiguity. Based @EliahKagan's suggestion and feedback on: gitpython-developers#1901
- Make the link text for the OSS-Fuzz test status URL more descriptive - Fix capitalization of GitPython repository name Based @EliahKagan's suggestion and feedback on: gitpython-developers#1901
Replaces the null character delimiter `-d $'\0'` with the simpler empty string `-d ''` in the fuzzing harness build loop. This changes leverages the Bash `read` builtin behavior to avoid unnecessary complexity and improving script readability. Based @EliahKagan's suggestion and feedback on: gitpython-developers#1901
Based @EliahKagan's suggestion and feedback on: gitpython-developers#1901
A misspelling in the https://github.com/gitpython-developers/qa-assets repository is still present here. It will need to be fixed in that repository first. "corpora" is a difficult word to spell consistently I guess. This made for a good opportunity to improve the phrasing of two other comments at at least. Based @EliahKagan's suggestion and feedback on: gitpython-developers#1901
DaveLak
marked this pull request as ready for review
April 17, 2024 16:06
EliahKagan
approved these changes
Apr 17, 2024
This PR addresses most unresolved review comments from #1901. It also updates the README
Addressed in This PR
build.shwith ShellCheck directive (Comment)fuzzing/oss-fuzz-scripts/container-environment-bootstrap.shto mark it executable in Git (Comment)fuzzing/README.mdfor the OSS-Fuzz test status URL more descriptive (Comment)fuzzing/README.md(Comment)build.sh's build fuzz harness loop (Comment)fuzzing/oss-fuzz-scripts/container-environment-bootstrap.shfor consistent script formatting (Comment)Misc
undefinedas a valid option in google/oss-fuzz@b210fb2(#11803) (Context: Comment in OSS-Fuzz PR #11803)TODO / Pending Further Discussion
I felt that these items are better addressed in separate PRs.
Add GitPython's standard license header comments to non-Apache 2.0 licensed files (Comment)Done in Add GitPython's Standard License Header Comments to Shell Scripts #1907fuzzing/fuzz-targets/fuzz_tree.pyrefactoring (Comment 1 & Comment 2)$SRC,$OUT, &$WORK) infuzzing/oss-fuzz-scripts(Comment)