Skip to content

C#: Add some logging messages for lazily computed sets of dependencies. - #22601

Merged
michaelnebel merged 1 commit into
github:mainfrom
michaelnebel:csharp/feedmanagerlogging
Sep 18, 2026
Merged

C#: Add some logging messages for lazily computed sets of dependencies.#22601
michaelnebel merged 1 commit into
github:mainfrom
michaelnebel:csharp/feedmanagerlogging

Conversation

@michaelnebel

@michaelnebel michaelnebel commented Sep 17, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Improve the FeedManager logging.

@github-actions github-actions Bot added the C# label Sep 17, 2026
@michaelnebel
michaelnebel force-pushed the csharp/feedmanagerlogging branch from d17a242 to 72d8db8 Compare September 17, 2026 11:24
@michaelnebel
michaelnebel requested a balanced review from Copilot September 17, 2026 11:26
Copilot AI reviewed Sep 17, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The logging additions accurately describe existing lazy computations and introduce no functional changes.

Review effort: Balanced
Findings: None

What changed in this PR

Adds informational logging around lazy NuGet feed discovery without changing feed selection behavior.

Changes:

  • Logs discovery of explicit, inherited, fallback, default, and aggregate feed sets.
  • Preserves lazy evaluation.
File Description
csharp/​extractor/​Semmle.Extraction.CSharp.DependencyFetching/​FeedManager.cs Adds feed-discovery log messages.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@michaelnebel michaelnebel added the no-change-note-required This PR does not need a change note label Sep 17, 2026
@michaelnebel
michaelnebel marked this pull request as ready for review September 18, 2026 07:50
@michaelnebel
michaelnebel requested a review from a team as a code owner September 18, 2026 07:51
hvitved
hvitved approved these changes Sep 18, 2026
View reviewed changes

@hvitved hvitved left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also be LogDebug; I'll let you decide.

@michaelnebel

michaelnebel commented Sep 18, 2026

Copy link
Copy Markdown
Contributor Author

Could also be LogDebug; I'll let you decide.

Thx! I would like to keep it as LogInfo. Further downstream, we log some other information (using LogInfo) and it is somewhat confusing what the origin of that information is due to the laziness in the FeedManager.

@michaelnebel
michaelnebel merged commit ba3f0b2 into github:main Sep 18, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort, defaults to Balanced
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@hvitved hvitved hvitved approved these changes

Assignees

No one assigned

Labels

C# no-change-note-required This PR does not need a change note

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@michaelnebel @hvitved