Avoid setting baseUrl to undefined when input is not provided - #439
Merged
Merged
Conversation
joshmgross
temporarily deployed
to
debug-integration-test
November 17, 2023 17:03 — with 
GitHub Actions
Inactive
|
Hello from actions/github-script! (52c67b9) |
joshmgross
commented
Nov 17, 2023
| return endpoint({url: "/graphql"}).url | ||
| result-encoding: string | ||
|
|
||
| - run: | |
Contributor
Author
There was a problem hiding this comment.
I don't love maintaining all these bash scripts for the integration tests in the workflow, but we can improve later and fix all of the integrationt tests at once.
zaataylor
approved these changes
Nov 17, 2023
Merged
kayman-mk
referenced
this pull request
in Hapag-Lloyd/Renovate-Global-Configuration
Nov 19, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/github-script](https://togithub.com/actions/github-script) | action | major | `v6.4.0` -> `v7.0.1` | --- ### Release Notes <details> <summary>actions/github-script (actions/github-script)</summary> ### [`v7.0.1`](https://togithub.com/actions/github-script/releases/tag/v7.0.1) [Compare Source](https://togithub.com/actions/github-script/compare/v7.0.0...v7.0.1) ##### What's Changed - Avoid setting `baseUrl` to undefined when input is not provided by [@​joshmgross](https://togithub.com/joshmgross) in [https://github.com/actions/github-script/pull/439](https://togithub.com/actions/github-script/pull/439) **Full Changelog**: actions/github-script@v7.0.0...v7.0.1 ### [`v7.0.0`](https://togithub.com/actions/github-script/releases/tag/v7.0.0) [Compare Source](https://togithub.com/actions/github-script/compare/v6.4.1...v7.0.0) ##### What's Changed - Add base-url option by [@​robandpdx](https://togithub.com/robandpdx) in [https://github.com/actions/github-script/pull/429](https://togithub.com/actions/github-script/pull/429) - Expose async-function argument type by [@​viktorlott](https://togithub.com/viktorlott) in [https://github.com/actions/github-script/pull/402](https://togithub.com/actions/github-script/pull/402), see for details https://github.com/actions/github-script#use-scripts-with-jsdoc-support - Update dependencies and use Node 20 by [@​joshmgross](https://togithub.com/joshmgross) in [https://github.com/actions/github-script/pull/425](https://togithub.com/actions/github-script/pull/425) ##### New Contributors - [@​navarroaxel](https://togithub.com/navarroaxel) made their first contribution in [https://github.com/actions/github-script/pull/285](https://togithub.com/actions/github-script/pull/285) - [@​robandpdx](https://togithub.com/robandpdx) made their first contribution in [https://github.com/actions/github-script/pull/429](https://togithub.com/actions/github-script/pull/429) - [@​viktorlott](https://togithub.com/viktorlott) made their first contribution in [https://github.com/actions/github-script/pull/402](https://togithub.com/actions/github-script/pull/402) **Full Changelog**: actions/github-script@v6.4.1...v7.0.0 ### [`v6.4.1`](https://togithub.com/actions/github-script/releases/tag/v6.4.1) [Compare Source](https://togithub.com/actions/github-script/compare/v6.4.0...v6.4.1) #### What's Changed - Add [@​octokit/plugin-request-log](https://togithub.com/octokit/plugin-request-log), to produce debug output for requests by [@​mjpieters](https://togithub.com/mjpieters) in [https://github.com/actions/github-script/pull/358](https://togithub.com/actions/github-script/pull/358) - fix input handling by [@​mjpieters](https://togithub.com/mjpieters) in [https://github.com/actions/github-script/pull/357](https://togithub.com/actions/github-script/pull/357) - Remove unused dependencies by [@​mjpieters](https://togithub.com/mjpieters) in [https://github.com/actions/github-script/pull/356](https://togithub.com/actions/github-script/pull/356) - Default debug to current runner debug state by [@​mjpieters](https://togithub.com/mjpieters) in [https://github.com/actions/github-script/pull/363](https://togithub.com/actions/github-script/pull/363) #### New Contributors - [@​mjpieters](https://togithub.com/mjpieters) made their first contribution in [https://github.com/actions/github-script/pull/358](https://togithub.com/actions/github-script/pull/358) **Full Changelog**: actions/github-script@v6.4.0...v6.4.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Hapag-Lloyd/Renovate-Global-Configuration). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
fuxingloh
referenced
this pull request
in fuxingloh/xmatter
Nov 20, 2023
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [actions/github-script](https://togithub.com/actions/github-script) | action | patch | `v7.0.0` -> `v7.0.1` | --- ### Release Notes <details> <summary>actions/github-script (actions/github-script)</summary> ### [`v7.0.1`](https://togithub.com/actions/github-script/releases/tag/v7.0.1) [Compare Source](https://togithub.com/actions/github-script/compare/v7.0.0...v7.0.1) ##### What's Changed - Avoid setting `baseUrl` to undefined when input is not provided by [@​joshmgross](https://togithub.com/joshmgross) in [https://github.com/actions/github-script/pull/439](https://togithub.com/actions/github-script/pull/439) **Full Changelog**: actions/github-script@v7.0.0...v7.0.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/levaintech/frontmatter). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy41OS44IiwidXBkYXRlZEluVmVyIjoiMzcuNTkuOCIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
duwenxin99
referenced
this pull request
in GoogleCloudPlatform/cymbal-air-toolbox-demo
Nov 20, 2023
Fixes #436
Replaces #437
Due to how options are passed through
@actions/githubto Octokit, anundefinedbaseUrlprevents the default from being used. This breaks using github-script on GHES, which requires the GHES instance API URL.#437 attempted to reproduce this issue in a test, but it was unsuccessful. There's a similar issue in the integration test, but the fix doesn't work despite it being confirmed in #436 (comment).
I've included the other integration tests, but they don't cover this specific scenario or what we're trying to fix.