Skip to content

Fix typo in README - #285

Merged
joshmgross merged 3 commits into
actions:mainfrom
navarroaxel:patch-1
Apr 7, 2023
Merged

joshmgross merged 3 commits into
actions:mainfrom
navarroaxel:patch-1

Conversation

@navarroaxel

Copy link
Copy Markdown
Contributor

No description provided.

@navarroaxel
navarroaxel requested a review from a team August 19, 2022 17:33
Comment thread README.md
body: `**Welcome**, new contributor!

Please make sure you're read our [contributing guide](CONTRIBUTING.md) and we look forward to reviewing your Pull request shortly ✨`
Please make sure you've read our [contributing guide](CONTRIBUTING.md) and we look forward to reviewing your Pull request shortly ✨`

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this better

Suggested change
Please make sure you've read our [contributing guide](CONTRIBUTING.md) and we look forward to reviewing your Pull request shortly ✨`
Please make sure you've read our [contributing guide](CONTRIBUTING.md) and we'll look forward to reviewing your Pull request shortly ✨`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"look forward" is already somewhat future, you don't need another "will". You suggestion means something else: "we don't look forward to reviewing now, but we will".

@TWiStErRob

Copy link
Copy Markdown

Try again

@navarroaxel

Copy link
Copy Markdown
Contributor Author

Try again

I used the update branch button in the GitHub web interface but using the rebase strategy. The result wasn't what I was expecting. 🤷‍♂️

@TWiStErRob

Copy link
Copy Markdown

Yeah, for that button press it was really unexpected then...

@joshmgross
joshmgross temporarily deployed to debug-integration-test April 7, 2023 15:50 — with GitHub Actions Inactive
@joshmgross
joshmgross temporarily deployed to debug-integration-test April 7, 2023 22:05 — with GitHub Actions Inactive
@joshmgross
joshmgross merged commit 060d683 into actions:main Apr 7, 2023
duwenxin99 referenced this pull request in GoogleCloudPlatform/cymbal-air-toolbox-demo Nov 15, 2023