Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changing an existing index from
UNIQUEtoINDEXupdates its rendered type but leavesgetKind()atUNIQUE. Consumers rewriting CREATE/ALTER TABLE statements can therefore observe a classification that no longer matches the type they assigned.Derive the classification on every
setType/withTypecall through one helper. Null and custom types clear stale classifications, keyword matching respects word boundaries, and original spelling is preserved.setKindremains an explicit metadata override without rewriting SQL, supporting declarations that store the index keyword separately and specialized constraint nodes.Validation: Gradle
checkpassed (7502 tests, 0 failures, 0 errors, 25 skipped), including formatting, static analysis and the grammar check. Regression tests cover repeated edits, all prior classifications, custom/null types, subclass defaults and CREATE TABLE deparse/reparse. Eight original/rewritten DDL cases executed successfully on MySQL 8.4.11 and PostgreSQL 18.6.Syntax references: MySQL CREATE TABLE, PostgreSQL CREATE TABLE.