fix(wait-strategy): close HTTPError in HttpWaitStrategy to avoid fd leak - #1118
Open
BrunosGits wants to merge 1 commit into
Open
BrunosGits wants to merge 1 commit into
BrunosGits wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1115: when an endpoint polled by HttpWaitStrategy answers with an error status, the raised HTTPError was never closed, leaking a file descriptor per poll (surfaces as ResourceWarning: Implicitly cleaning up <HTTPError ...> from tempfile.del).
Root cause
In _try_http_request, urlopen raises HTTPError for error statuses, so the with-block never owns it. The except arm forwards the error to _handle_http_error, which inspected error.code and returned without closing it. HTTPError wraps the response body fp, so each failed poll held an fd until GC.
Changes
Testing
Closes #1115