Conversation
|
|
frojasg
marked this pull request as ready for review
September 16, 2026 00:41
Contributor
|
Hi, thank you for the contribution. Before we review your PR could you please sign the CLA |
Author
|
Done signing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Catch
RejectedExecutionExceptionwhen a poll loop re-submits itself and its executor has shut down. Rejections from an executor that is still running continue to reach the uncaught exception handler.Why?
MultiThreadedPollerchecksshouldTerminate()before it schedules the next poll. Shutdown can start between that check andexecute(this). The resulting rejection escapes fromfinally, bypasses the shutdown-aware handler, and produces an ERROR log during normal worker shutdown.The catch handles that race without changing task handoff or shutdown ordering. It checks the executor's shutdown state, so thread interruption alone cannot suppress an unexpected rejection.
Validation
The two new shutdown-race tests fail on the original code and pass with this change. Tests also verify that running-executor rejections remain visible, including on an interrupted thread.
On Java 21, formatting, SDK assembly, and all 13 tests across
MultiThreadedPollerTest,GracefulPollShutdownTest,ShutdownManagerTest, andWorkerShutdownTestpassed. The full test suite was not run locally.Breaking changes?
None. No public API changes.
Server PR
None required.
Generated with Codex