Fix annotation upload retries and exhausted retry counts - #528
Open
mstevens843 wants to merge 1 commit into
Open
mstevens843 wants to merge 1 commit into
mstevens843 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Project.save_annotation()constructs aRetryobject but calls the adapter directly, sonum_retry_uploadsis ignored when saving annotations.This routes annotation saves through the existing retry helper. It also fixes exhausted retry counts in both annotation and image uploads: the exception handlers now read the live counter instead of a value only updated after success.
This follows up on the retry behavior introduced in #362. Default retry budgets, retryable exception types, and argument forwarding remain unchanged.
Tests
Added 12 regression tests covering:
Local validation:
HTTP responses are mocked and retry sleeps are patched, so the tests do not depend on network availability or backoff timing.