Make WritableStreamDefaultWriter.write contravariant in its chunk type - #64339
Draft
Ryan Cavanaugh (RyanCavanaugh) with Copilot wants to merge 3 commits into
Draft
Ryan Cavanaugh (RyanCavanaugh) with Copilot wants to merge 3 commits into
Ryan Cavanaugh (RyanCavanaugh) with Copilot wants to merge 3 commits into
Conversation
Copilot started work on behalf of
Ryan Cavanaugh (RyanCavanaugh)
September 19, 2026 01:52
View session
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Co-authored-by: RyanCavanaugh <6685088+RyanCavanaugh@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Consider making WritableStreamDefaultWriter.write() contravariant
Make WritableStreamDefaultWriter.write contravariant in its chunk type
Sep 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WritableStreamDefaultWriter<W>declaredwriteas a method, so its parameter was compared bivariantly.WreachesWritableStream<W>only throughgetWriter(), so the entire stream type was bivariant in its chunk type, accepting unsound assignments:Wis only ever consumed, never produced, so bivariance buys nothing here.Changes
lib.dom.d.ts/lib.webworker.d.ts: declarewriteas a function property (write: (chunk?: W) => Promise<void>;), makingWritableStream<W>contravariant inWunderstrictFunctionTypes. Both cases above now error; widening in the sound direction (WritableStream<{ a }>whereWritableStream<{ a; b }>is expected) still compiles.writableStreamChunkVariance.tsplus baselines, committed pre-fix (no errors) and then updated, so the behavior change is visible in the diff.These lib files are generated from TypeScript-DOM-lib-generator; the same change needs to be mirrored upstream to survive regeneration.
WritableStreamDefaultWriter.write()contravariant #59012