[api] Make optional properties of project references optional - #64326
Open
Andrew Branch (andrewbranch) wants to merge 2 commits into
Open
Andrew Branch (andrewbranch) wants to merge 2 commits into
Andrew Branch (andrewbranch) wants to merge 2 commits into
Conversation
typescript-automation
Bot
added
Author: Team
For Uncommitted Bug
Copilot started reviewing on behalf of
Andrew Branch (andrewbranch)
September 18, 2026 23:01
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Existing sync and async response tests still expect circular: false and will fail with the new serialization.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Makes optional project-reference fields optional in the TypeScript API.
Changes:
- Adds
omitemptyto Go JSON fields. - Regenerates optional TypeScript properties.
- Adds an async API type assertion.
| File | Description |
|---|---|
tsc/internal/core/projectreference.go |
Makes optional fields omittable during JSON serialization. |
packages/typescript/src/api/proto.generated.ts |
Exposes optional project-reference properties. |
packages/typescript/test/async/api.test.ts |
Verifies references require only path. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
| OriginalPath string `json:"originalPath,omitempty"` | ||
| // Circular indicates that this reference is intended to form a circularity. | ||
| Circular bool `json:"circular"` | ||
| Circular bool `json:"circular,omitempty"` |
Ryan Cavanaugh (RyanCavanaugh)
approved these changes
Sep 18, 2026
Andrew Branch (andrewbranch)
enabled auto-merge
September 19, 2026 00:09
Andrew Branch (andrewbranch)
requested a review
from Ryan Cavanaugh (RyanCavanaugh)
September 19, 2026 00:09
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.