Skip to content

Add ARM CI Jobs - #64325

Merged
Wesley Wigham (weswigham) merged 8 commits into
mainfrom
weswigham-patch-1
Sep 19, 2026
Merged

Wesley Wigham (weswigham) merged 8 commits into
mainfrom
weswigham-patch-1

Conversation

@weswigham

Copy link
Copy Markdown
Member

Add some ARM CI jobs so we catch ARM-specific test failures.

Add some ARM CI jobs so we catch ARM-specific test failures.
Copilot AI balanced review requested due to automatic review settings September 18, 2026 19:32
@github-project-automation github-project-automation Bot moved this to Not started in PR Backlog Sep 18, 2026
@typescript-automation typescript-automation Bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Sep 18, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Both new jobs still select x64 runner labels, so no ARM64 tests execute.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds ARM64 CI coverage for Linux and Windows.

Changes:

  • Adds ARM64 entries to the test matrix.
  • Retains coverage and merge-group behavior.
File summaries
File Description
.github/workflows/ci.yml Adds Linux and Windows ARM64 test configurations.
Review details

Suppressed comments (1)

.github/workflows/ci.yml:103

  • This also selects an x64 host because runs-on uses matrix.config.runner, while arch is otherwise unused. Set the Windows ARM runner label directly so the matrix actually exercises ARM64.
          - runner: windows-latest
            os: windows
            arch: arm64
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/ci.yml Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

ARM jobs can collide with existing baseline artifact names during concurrent failures.

Get a fresh assessment by requesting another Copilot review.

Review details

Suppressed comments (1)

.github/workflows/ci.yml:103

  • This ARM entry falls back to matrix.config.os for failed-test artifacts, producing windows-new-baselines, which is already used by the x64 Windows job. Concurrent failures therefore make one immutable artifact upload conflict and discard that job's baselines. Assign a unique matrix name here.
          - runner: windows-11-arm
            os: windows
            coverage: true
            skip: ${{ github.event_name == 'merge_group' }}
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced

Comment thread .github/workflows/ci.yml

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The runner labels are valid and the new matrix entries correctly reuse the existing test workflow.

Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0 new
  • Review effort level: Balanced

@jakebailey

Copy link
Copy Markdown
Member

This seems fine, but didn't expose any problems, and I am at least moderately concerned about the capacity here. Hopefully they have enough, unlike macOS.

@weswigham

Copy link
Copy Markdown
Member Author

They completed before the osx runner I think, so I think they're worth having. Also, looking at the CI results, they're actually faster than the x86 test runners - go figure. (And linux arm runners are even billed at a cheaper rate than x64, apparently.)

@github-project-automation github-project-automation Bot moved this from Not started to Needs merge in PR Backlog Sep 19, 2026
@weswigham
Wesley Wigham (weswigham) added this pull request to the merge queue Sep 19, 2026
Merged via the queue into main with commit 2c99d08 Sep 19, 2026
29 checks passed
@weswigham
Wesley Wigham (weswigham) deleted the weswigham-patch-1 branch September 19, 2026 08:29
@github-project-automation github-project-automation Bot moved this from Needs merge to Done in PR Backlog Sep 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants