perf: preallocate inherited member symbol table - #64321
Open
Cameron (camc314) wants to merge 1 commit into
Open
Cameron (camc314) wants to merge 1 commit into
Cameron (camc314) wants to merge 1 commit into
Conversation
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
typescript-automation
Bot
added
the
For Uncommitted Bug
Member
|
Zero duplication, but, how many hints are too large? might not matter as Go maps typically already start with size 8 or something, so I'm not sure if this does much |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since we know how big the map is going to be, we can pre allocate and avoid a re-allocation.
Same as the previous PR, I checked, and there are zero duplicated based names: