copilot: stop sending empty agent-assignment strings and report session detection honestly - #3297
Open
Flanxiyum001 wants to merge 1 commit into
Open
Flanxiyum001 wants to merge 1 commit into
Flanxiyum001 wants to merge 1 commit into
Conversation
Refactor agent assignment input preparation to avoid unnecessary empty string pointers and improve clarity. Update success messages to reflect the actual state of pull request creation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #3283
Hardening changes for the Copilot assignment tools, from the investigation in
#3283. The root cause (object-form
assigneessilently dropping the agentassignment in the intent processor) is server-side; this PR fixes the
client-side issues identified there.
AgentAssignmentInputno longer setsCustomAgent/CustomInstructionstopointers of
"". Sinceomitemptyon*githubv4.Stringonly drops nilpointers,
"customAgent": ""was reaching the wire on both assign tools,while the working manual/UI path omits these fields entirely.
agent_session_detected: falsewith an explicit warning message instead ofan unqualified "successfully assigned … pull request pending", so callers
stop treating a dead session as success. On success,
agent_session_detected: trueis reported.