Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #25413 +/- ##
==========================================
+ Coverage 81.94% 82.33% +0.38%
==========================================
Files 1135 1137 +2
Lines 428278 432064 +3786
Branches 428278 432064 +3786
==========================================
+ Hits 350952 355737 +4785
+ Misses 56369 54822 -1547
- Partials 20957 21505 +548 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
For
RightSemiandRightAntinested loop joins, each right row only needs one match to determine whether it belongs in the result. Currently, matched right rows continue participating in comparisons with subsequent left rows.Skipping these comparisons can significantly reduce execution time when matches are found early.
What changes are included in this PR?
RightExistenceProbeto track matches and right-side candidates.What is the testing strategy for this PR?
nested_loop_join_existence.sltfor RightSemi/RightAnti joins, including NULLs, repeated matches, and multiple left rows per probe.nested_loop_join_spill.sltto cover RightSemi/RightAnti joins across spilled left chunks.Are there any user-facing changes?
No. This is an internal performance optimization.
Benchmark results