Skip to content

Move App Doctor route authentication review to the agent - #8596

Open
lopez-mar wants to merge 1 commit into
mainfrom
lopez-mar/app-doctor-agentic-auth
Open

lopez-mar wants to merge 1 commit into
mainfrom
lopez-mar/app-doctor-agentic-auth

Conversation

@lopez-mar

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

The deterministic route-auth check treats an unrecognized authentication spelling as a vulnerability. Valid load-context, dependency-injection, and middleware patterns can therefore produce false positives, while matching authentication text does not prove it protects the operation.

WHAT is this pull request doing?

Move UNAUTHENTICATED_ENDPOINT to agentic-only review and strengthen its prompt to trace the real verification path before protected operations. Preserve the check's identity and unresolved agent execution until a review is reported; deterministic-only scans no longer claim this check ran.

Remove the obsolete matcher and its tests, add a scan-to-review handoff regression, and update the catalog, embedded prompts, and deterministic-only guidance. Authentication review still requires a coding agent; this does not depend on the new agent loop in #8591.

How to manually test your changes?

pnpm shopify app doctor --path /path/to/react-router-app --json --skip-instructions
pnpm shopify app doctor instructions --path /path/to/react-router-app

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing and includes a patch changeset.

Assisted-By: devx/6a87267f-002b-45a7-a964-2b150210ff87
@lopez-mar
lopez-mar requested a review from a team as a code owner September 18, 2026 21:11
@github-actions github-actions Bot added the Area: @shopify/app @shopify/app package issues label Sep 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/app @shopify/app package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant