Skip to content

Prevent App Doctor rescans from dropping compiled findings - #8594

Draft
jek wants to merge 1 commit into
mainfrom
app-doctor/findings-merge
Draft

jek wants to merge 1 commit into
mainfrom
app-doctor/findings-merge

Conversation

@jek

@jek jek commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

WHY are these changes introduced?

Fixes #23971

Warn agents not to rerun the initial scan after compiling findings, because a new deterministic scan replaces the compiled trace.

Test coverage of dry-run and live submission to ensure neither modifies a compiled trace containing agent findings.

WHAT is this pull request doing?

How to manually test your changes?

Post-release steps

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing — I've identified the correct bump type (patch for bug fixes · minor for new features · major for breaking changes) and added a changeset with pnpm changeset add

Assisted-By: devx/a43d5d42-941f-47ca-ba7d-47133d5a8cc6

@github-actions github-actions Bot added the Area: @shopify/app @shopify/app package issues label Sep 18, 2026
Refuse to start a new scan when agent findings or compiled review results
already exist, preventing the deterministic scan from replacing that work.

Add --clean for explicitly discarding the current review and starting over,
and update the generated agent instructions to describe the guarded flow.

Co-authored-by: AI <noreply@pi.dev>
Assisted-By: devx/a43d5d42-941f-47ca-ba7d-47133d5a8cc6
@jek
jek force-pushed the app-doctor/findings-merge branch from 1463dad to 25d5c2d Compare September 18, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: @shopify/app @shopify/app package issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant