Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: ruby/fileutils
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: master
Choose a base ref
...
head repository: ruby/fileutils
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ruby-2-6-fileutils
Choose a head ref
Checking mergeability… Don’t worry, you can still create the pull request.
  • 11 commits
  • 4 files changed
  • 5 contributors

Commits on Feb 16, 2023

  1. Dir.children is available since Feature #11302. FileUtils uses 

    Dir.each on an internal method encapsulated on a private class
`Entry_#entry`, having no '.' neither '..' entries would make
now superfluous a chained reject filtering.

This change can improve the performance of these FileUtils
methods when the provided path covers thousands of files or
directories:

- chmod_R
- chown_R
- remove_entry
- remove_entry_secure
- rm_r
- remove_dir
- copy_entry

Related: Feature #13896 https://bugs.ruby-lang.org/issues/13896

[Feature #14109][Fix GH-1754]

Co-Authored-By: esparta <esparta@gmail.com>

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65610 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
    @hsbt
    hsbt committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    aaaf4f8 View commit details
    Browse the repository at this point in the history

  2. merge revision(s) 66972: [Backport #15577] 

    	Fix exception namespace

	* lib/fileutils.rb (remove_entry_secure): EISDIR is under the
	  Errno namespace.  [ruby-core:91362] [Bug #15577]

	From: Tietew (Toru Iwase) <tietew@tietew.net>

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67177 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
    @nurse @hsbt
    nurse authored and hsbt committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    01860be View commit details
    Browse the repository at this point in the history

  3. merge revision(s) 66973: [Backport #15577] 

    	Run r66972 assertion only when a sticky-bit makes sense

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67210 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
    @nurse @hsbt
    nurse authored and hsbt committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    8adc41f View commit details
    Browse the repository at this point in the history

  4. merge revision(s) 67247: [Backport #15666] 

    	Guard out the test when it is run under root permission

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67351 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
    @nurse @hsbt
    nurse authored and hsbt committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    ec46a55 View commit details
    Browse the repository at this point in the history

  5. merge revision(s) a19228f8: [Backport #16979] 

    	brace the fact that lchmod(2) can EOPNOTSUPP

	Musl libc has this function as a tiny wrapper of fchmodat(3posix).  On
	the other hand Linux kernel does not support changing modes of a symlink.
	The operation always fails with EOPNOTSUPP.  This fchmodat behaviour is
	defined in POSIX.  We have to take care of such exceptions.
	---
	 lib/fileutils.rb               |  3 ++-
	 test/pathname/test_pathname.rb |  2 +-
	 test/ruby/test_notimp.rb       | 19 ++++++++++++-------
	 3 files changed, 15 insertions(+), 9 deletions(-)

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/branches/ruby_2_6@67907 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
    @unak @hsbt
    unak authored and hsbt committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    86846ce View commit details
    Browse the repository at this point in the history

  6. Retry to merge fileutils-1.1.0. 

      * Revert "Revert "Merge fileutils-1.1.0.""
    This reverts commit 84bb8e81c25d4d7d6020c3acfbbc36e9064200fa.

  * Added workaround for make mjit-headers

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63430 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
    @hsbt
    hsbt committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    da8aa31 View commit details
    Browse the repository at this point in the history

  7. fileutils.rb: restore documentation for FileUtils 

    * lib/fileutils.rb: [DOC] restore documentation for FileUtils module
  which became undocumented with r63430.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@64911 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
    @stomar @hsbt
    stomar authored and hsbt committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    4d656b5 View commit details
    Browse the repository at this point in the history

  8. Merge fileutils from ruby/fileutils on GitHub. 

      * It was separated version file for gemspec.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65207 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
    @hsbt
    hsbt committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    0af35dd View commit details
    Browse the repository at this point in the history

  9. Added workaround to fileutils for make btest without rbconfig. 

      Followed up r63430.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63434 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
    @hsbt
    hsbt committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    b4a92a8 View commit details
    Browse the repository at this point in the history

  10. fileutils.rb: remove code for OS/2 emx 

    * lib/fileutils.rb (FileUtils#mv): remove code for OS/2 emx, its
  support has been dropped yeas ago.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63440 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
    @nobu @hsbt
    nobu authored and hsbt committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    6136d96 View commit details
    Browse the repository at this point in the history

  11. fileutils.rb: split fu_windows? 

    * lib/fileutils.rb (FileUtils::StreamUtils_#fu_windows?): select
  the method definition for each platforms, and dropped supports
  for deprecated platforms.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@63465 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
    @nobu @hsbt
    nobu authored and hsbt committed Feb 16, 2023
    Configuration menu
    Copy the full SHA
    5f50ab3 View commit details
    Browse the repository at this point in the history
Loading